Fix handling of backend crashes during standby promotion If a backend crashed as a standby finishes promotion, the server could resume normal operation without resetting shared memory and performing crash recovery. With restart_after_crash disabled, it could keep running instead of shutting down as required.
This happened when the postmaster detected the backend crash and sent SIGQUIT to the startup process, but that process had already exited or was too far along in its normal exit sequence to respond to the signal. The postmaster then treated its zero exit status as successful startup, clearing FatalError and entering PM_RUN despite the backend crash. Fix this by honoring STARTUP_SIGNALED even when the startup process exits with status zero. This lets the postmaster finish handling the crash and either restart or shut down, according to restart_after_crash. A failure of 041_checkpoint_at_promote.pl on buildfarm member tamandua exposed this race in the server's handling of backend crashes. Although the test was introduced in v17, the bug affects all supported versions. Backpatch to all supported versions. Reported-by: Alexander Lakhin <[email protected]> Author: Ayush Tiwari <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2bce773e2e847a039d2d5728e19e6d067854655e Modified Files -------------- src/backend/postmaster/postmaster.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
