Fix pgstattuple_approx handling of unknown tuple estimates vac_estimate_reltuples() can return -1 when there is not enough information to estimate the number of live tuples. pgstattuple_approx() assigned that value to an unsigned counter before attempting to clamp it, making the clamp ineffective and exposing -1 through the bigint result.
Clamp the signed estimate before assigning it to the unsigned counter. Reported-by: Zsolt Parragi <[email protected]> Author: Melanie Plageman <[email protected]> Reviewed-by: Lukas Fittl <[email protected]> Reviewed-by: Zsolt Parragi <[email protected]> Discussion: https://postgr.es/m/CAN4CZFM0y8t%2BAQ8PWTeuBXnFtRDUNvkfVzzA_yo6uJ2bceK%3DxA%40mail.gmail.com Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/371565fc57f864942baf19520b2983e448e5b0e5 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 12 ++++++++++++ contrib/pgstattuple/pgstatapprox.c | 9 +++++---- contrib/pgstattuple/sql/pgstattuple.sql | 10 ++++++++++ doc/src/sgml/pgstattuple.sgml | 3 ++- 4 files changed, 29 insertions(+), 5 deletions(-)
