On Thu, May 19, 2005 at 06:35:48PM -0300, Tom Lane wrote:
> Log Message:
> -----------
> Split the shared-memory array of PGPROC pointers out of the sinval
> communication structure, and make it its own module with its own lock.
> This should reduce contention at least a little, and it definitely makes
> the code seem cleaner.  Per my recent proposal.

Excellent.  May I suggest the following so pgindent does not mess up
this comment:

-- 
Alvaro Herrera (<alvherre[a]surnet.cl>)
"El realista sabe lo que quiere; el idealista quiere lo que sabe" (An�nimo)
Index: xact.c
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/backend/access/transam/xact.c,v
retrieving revision 1.201
diff -c -r1.201 xact.c
*** xact.c      19 May 2005 21:35:45 -0000      1.201
--- xact.c      19 May 2005 22:42:45 -0000
***************
*** 1498,1504 ****
         */
        RecordTransactionCommit();
  
!       /*
         * Let others know about no transaction in progress by me. Note that
         * this must be done _before_ releasing locks we hold and _after_
         * RecordTransactionCommit.
--- 1498,1504 ----
         */
        RecordTransactionCommit();
  
!       
/*-----------------------------------------------------------------------
         * Let others know about no transaction in progress by me. Note that
         * this must be done _before_ releasing locks we hold and _after_
         * RecordTransactionCommit.
***************
*** 1510,1515 ****
--- 1510,1516 ----
         * xid 0 as running as well, or it will be able to see two tuple 
versions
         * - one deleted by xid 1 and one inserted by xid 0.  See notes in
         * GetSnapshotData.
+        
*-----------------------------------------------------------------------
         */
        if (MyProc != NULL)
        {
---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to