On Wed, 6 Sep 2006, Teodor Sigaev wrote: > Log Message: > ----------- > Fix compiler warnings on 64-bit boxes: difference between > pointers are int64, but warnings are emitted for position info in > error messages in parser, so, just cast it to int32 > > Modified Files: > -------------- > pgsql/contrib/hstore: > hstore_io.c (r1.1 -> r1.2) > > (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/hstore/hstore_io.c.diff?r1=1.1&r2=1.2)
It might seem a minor quibble, but it seems like a more reliable approach might be to cast to a 64 bit type and user a 64 bit int formatter. It seems unlikely that state->ptr - state->begin would yield a number that large but I don't know that that would be true of every platform or user. Thanks, Gavin ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
