Magnus Hagander wrote: > > > Comments like that are fragile (elog.c could change, for example), and > > > basically content-free anyway, IMHO. If you need to make SysLoggerPID > > > part of postmaster.c's external API, why not just do that, remove the > > > comment, and add the extern declaration to postmaster.h? > > > > The counterargument is that he avoided exporting SysLoggerPID to > > anything except elog.c. If it's in postmaster.h then who knows what > > will start depending on it? But I see Neil's point too; this coding > > is definitely a bit fragile. > > That was my argument for doing it the way I did. I'll change it if you > want me to, of course :-) I can see both arguments, but can't quite > decide which wins...
I add it so the commit message on HEAD also shows the back branchs. It makes it easier when creating the major release notes whether the patch has already appeared in a back branch, and hence shouldn't be mentioned. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
