Bruce Momjian wrote: > Log Message: > ----------- > PG_MAJORVERSION: > > For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation > of the PG_VERSION file.
I think this is a bad style to use for commit messages. For GIT, a good commit message is a first line being a summary, and a more extensive message below. The way you used a contentless first line means that somebody perusing a "git shortlog" or "git annotate" does not get any useful information out of it. It would have been better phrased like "Use PG_MAJORVERSION define to create the PG_VERSION file It is easier than using the PG_VERSION define." or similar. It is also bad for pgsql-committers list archives, because those get an extract of the first line too. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
