On Mon, Feb 22, 2010 at 2:54 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Actually, that code had *multiple* problems including stat'ing the wrong > file entirely, not to mention that this last commit failed to even > compile. I also think it should scan the todir not the fromdir, just on > general principles to avoid any possibility of race conditions.
Argh. I'll be less careless in the future, I promise. I had concluded that scanning the original directory was odd but better because it served to double-check that all the original files actually made it and also because if there were any unrelated files present there was no need to fsync them. But I agree it's odd and not very general for copydir if we decide to use it elsewhere other than create database. -- greg -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
