On Fri, Jul 2, 2010 at 9:19 AM, Magnus Hagander <[email protected]> wrote: > On Fri, Jul 2, 2010 at 2:13 PM, Robert Haas <[email protected]> wrote: >> On Fri, Jul 2, 2010 at 8:10 AM, Andrew Dunstan <[email protected]> wrote: >>> Robert Haas wrote: >>>> Log Message: >>>> ----------- >>>> Allow copydir() to be interrupted. >>>> >>> >>> This appears to have broken MinGW and Cygwin builds on the buildfarm. >> >> Well, that's not awesome. IM-ing with Magnus now. I'm wondering if >> this is a link-ordering problem of some kind. > > We've seen something like this before, but I don't recall what it was. > It's probably something getting resolved too early when it's built > into libpgport_srv.a. That would explain why it's working fine on MSVC > - we don't actually bother building a server-side .lib there, we just > link the object files directly into postgres.exe. (We do build the > library for client side, of course, since it's used in many different > binaries)
I wonder if we should just move copydir.c to someplace within the backend, perhaps backend/storage/file or backend/utils/misc. It's already backend-specific code anyway, so I'm not sure there's much point in having it in src/port. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
