Alvaro Herrera wrote: > Excerpts from Tom Lane's message of vie feb 18 00:34:33 -0300 2011: > > Bruce Momjian <[email protected]> writes: > > > Andrew Dunstan wrote: > > >> On 02/17/2011 08:23 PM, Alvaro Herrera wrote: > > >>> Use $INDENT rather than indent throughout the pgindent code > > >>> +INDENT=`which indent` > > > > >> How universally available is "which"? > > > > > I have 'which'. I am unclear how 'which' helps in this case. > > Hey, you could have asked when I showed you the patch yesterday on IM.
I thought I was missing something; I figured there must be some reason. > > It doesn't. Anything 'which' would find could perfectly well be invoked > > by saying plain old "indent". > > It helps because I can easily change the value in the script in a single > place to what I want. That's a bit less inconvenient than having to > edit more than one place. However ... > > > What would actually be useful here is a > > convenient way to override the script's default value of INDENT, but > > this coding doesn't offer that. I'd suggest something more like > > > > if [ -z "$INDENT" ]; then > > INDENT=indent > > fi > > ... this is certainly better. I'll change it to this. OK. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
