Andrew Dunstan <[email protected]> writes:
> Remove hard coded formats for INT64 and use configured settings instead.
I don't find this patch to be a good idea. The code was unconditionally
correct before, and now it isn't:
- sprintf(mallocedval + strlen(mallocedval), "%lld,",
((long long int *) var->value)[element]);
+ sprintf(mallocedval + strlen(mallocedval), INT64_FORMAT
",", ((long long int *) var->value)[element]);
"long long int" will match "%lld" by definition. It matches
INT64_FORMAT only if "long long int" is 64 bits. What's more,
this change will probably result in adding not subtracting warnings
on platforms where configure selects "%ld" for INT64_FORMAT.
Please revert.
regards, tom lane
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
