Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS. The previous coding resulted in contrib modules unintentionally overriding the use of CONTRIB_TESTDB. There seems no particularly good reason to allow that (after all, the makefile can set CONTRIB_TESTDB if that's really what it intends).
In passing, document REGRESS_OPTS where the other pgxs.mk options are documented. Back-patch to 9.1 --- in prior versions, there were no cases of contrib modules setting REGRESS_OPTS without including the --dbname switch, so while the coding was fragile there was no actual bug. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/d1d388603e4f9233d3e01847405b239972a54fdf Modified Files -------------- contrib/sepgsql/Makefile | 4 +++- doc/src/sgml/extend.sgml | 9 +++++++++ src/makefiles/pgxs.mk | 7 +++---- 3 files changed, 15 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
