Unify calling conventions for postgres/postmaster sub-main functions There was a wild mix of calling conventions: Some were declared to return void and didn't return, some returned an int exit code, some claimed to return an exit code, which the callers checked, but actually never returned, and so on.
Now all of these functions are declared to return void and decorated with attribute noreturn and don't return. That's easiest, and most code already worked that way. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/eeece9e60984e76e5a41c1e2fa9efc5a1761e560 Modified Files -------------- src/backend/main/main.c | 17 +++++++------- src/backend/postmaster/autovacuum.c | 4 +- src/backend/postmaster/pgarch.c | 2 +- src/backend/postmaster/pgstat.c | 2 +- src/backend/postmaster/postmaster.c | 38 +++++++++++++------------------- src/backend/postmaster/syslogger.c | 1 + src/backend/replication/walsender.c | 10 ++++---- src/backend/tcop/postgres.c | 9 +++++-- src/backend/utils/misc/help_config.c | 4 +- src/include/bootstrap/bootstrap.h | 2 +- src/include/pgstat.h | 2 +- src/include/postmaster/autovacuum.h | 4 +- src/include/postmaster/bgwriter.h | 4 +- src/include/postmaster/pgarch.h | 2 +- src/include/postmaster/postmaster.h | 4 +- src/include/postmaster/startup.h | 2 +- src/include/postmaster/syslogger.h | 2 +- src/include/postmaster/walwriter.h | 2 +- src/include/replication/walreceiver.h | 2 +- src/include/replication/walsender.h | 2 +- src/include/storage/ipc.h | 2 +- src/include/tcop/tcopprot.h | 4 +- src/include/utils/help_config.h | 2 +- 23 files changed, 60 insertions(+), 63 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
