Prevent corner-case core dump in rfree(). rfree() failed to cope with the case that pg_regcomp() had initialized the regex_t struct but then failed to allocate any memory for re->re_guts (ie, the first malloc call in pg_regcomp() failed). It would try to touch the guts struct anyway, and thus dump core. This is a sufficiently narrow corner case that it's not surprising it's never been seen in the field; but still a bug is a bug, so patch all active branches.
Noted while investigating whether we need to call pg_regfree after a failure return from pg_regcomp. Other than this bug, it turns out we don't, so adjust comments appropriately. Branch ------ REL9_0_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/f81d50dc87ae73f2817c67b205fdcf8d266ca3fb Modified Files -------------- src/backend/regex/regcomp.c | 24 +++++++++++++++--------- src/backend/utils/adt/regexp.c | 3 +-- 2 files changed, 16 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
