Improve pg_upgrade's load_directory() function. Error out on out-of-memory, rather than returning -1, which the sole existing caller wasn't checking for anyway. There doesn't seem to be any use-case for making the caller check for failure here.
Detect failure return from readdir(). Use a less platform-dependent method of calculating the entrysize. It's possible, but not yet confirmed, that this explains bug #6733, in which Mike Wilson reports a pg_upgrade crash that did not occur in 9.1. (Note that load_directory is effectively new code in 9.2, at least on platforms that have scandir().) Fix up comments, avoid uselessly using two counters, reduce the number of realloc calls to something sane. Branch ------ REL9_2_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/3d929dc7b8e982f12c62fecba7d5122bb22fa497 Modified Files -------------- contrib/pg_upgrade/file.c | 62 ++++++++++++++++++++------------------ contrib/pg_upgrade/pg_upgrade.h | 3 +- contrib/pg_upgrade/util.c | 13 +++++++- 3 files changed, 47 insertions(+), 31 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
