When converting a table to a view, remove its system columns. Views should not have any pg_attribute entries for system columns. However, we forgot to remove such entries when converting a table to a view. This could lead to crashes later on, if someone attempted to reference such a column, as reported by Kohei KaiGai.
Patch in HEAD only. This bug has been there forever, but in the back branches we will have to defend against existing mis-converted views, so it doesn't seem worthwhile to change the conversion code too. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/a4e8680a6c337955c021177457147f4b4d9a5df5 Modified Files -------------- src/backend/catalog/heap.c | 41 +++++++++++++++++++++++++++++++++++ src/backend/rewrite/rewriteDefine.c | 11 +++++++- src/include/catalog/heap.h | 1 + src/test/regress/expected/rules.out | 22 ++++++++++++++++++ src/test/regress/sql/rules.sql | 15 ++++++++++++ 5 files changed, 88 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
