Hi, On 2012-12-24 12:52:26 +0000, Simon Riggs wrote: > On 23 December 2012 21:49, Robert Haas <rh...@postgresql.org> wrote: > > Adjust many backend functions to return OID rather than void. > > > > Extracted from a larger patch by Dimitri Fontaine. It is hoped that > > this will provide infrastructure for enriching the new event trigger > > functionality, but it seems possibly useful for other purposes as > > well. > > Thanks for working on this, but the build farm is broken as a result of this. > > I fixed the first thing, but its still all in pieces. If you're around > please fix or revoke, if you're not, I'll do that.
There were some more of the same thing youve fixed, see the attached patch that fixes the rest, at least as far as I can see when compiling HEAD here. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
>From 2fe3e4ae80c21bf87fee8d0918d03de012f198ea Mon Sep 17 00:00:00 2001 From: Andres Freund <and...@anarazel.de> Date: Mon, 24 Dec 2012 17:09:25 +0100 Subject: [PATCH] Adapt some more function declarations to return Oid Those were missed in a previous commit that changed some more backend functions to return the Oid of the object that has been affected. It seems the commit didn't include some of the local changes. --- src/include/commands/event_trigger.h | 4 ++-- src/include/commands/tablecmds.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/commands/event_trigger.h b/src/include/commands/event_trigger.h index 459d27f..501da7c 100644 --- a/src/include/commands/event_trigger.h +++ b/src/include/commands/event_trigger.h @@ -36,8 +36,8 @@ extern void RemoveEventTriggerById(Oid ctrigOid); extern Oid get_event_trigger_oid(const char *trigname, bool missing_ok); extern void AlterEventTrigger(AlterEventTrigStmt *stmt); -extern void RenameEventTrigger(const char* trigname, const char *newname); -extern void AlterEventTriggerOwner(const char *name, Oid newOwnerId); +extern Oid RenameEventTrigger(const char* trigname, const char *newname); +extern Oid AlterEventTriggerOwner(const char *name, Oid newOwnerId); extern void AlterEventTriggerOwner_oid(Oid, Oid newOwnerId); extern bool EventTriggerSupportsObjectType(ObjectType obtype); diff --git a/src/include/commands/tablecmds.h b/src/include/commands/tablecmds.h index d0ef4ae..8c683ce 100644 --- a/src/include/commands/tablecmds.h +++ b/src/include/commands/tablecmds.h @@ -35,7 +35,7 @@ extern void ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, L extern void AlterTableInternal(Oid relid, List *cmds, bool recurse); -extern void AlterTableNamespace(AlterObjectSchemaStmt *stmt); +extern Oid AlterTableNamespace(AlterObjectSchemaStmt *stmt); extern void AlterTableNamespaceInternal(Relation rel, Oid oldNspOid, Oid nspOid, ObjectAddresses *objsMoved); -- 1.7.10.4
-- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
