On Tue, Jan 21, 2014 at 11:30 AM, Tom Lane <[email protected]> wrote: > Robert Haas <[email protected]> writes: >> Plug more memory leaks when reloading config file. > > Hm, not too sure about this hunk: > > ereport(LOG, > (errmsg("skipping missing configuration file \"%s\"", > abs_path))); > - return OK; > + OK = true; > + goto cleanup; > } > > That's changing the semantics, no? That is, what if OK was previously > false? Seems like this coding might be masking an intended failure > report. I'd have expected just "goto cleanup" without changing OK.
Good catch, sorry about that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
