On Wed, Jan 29, 2014 at 5:28 AM, Tom Lane <[email protected]> wrote: > Fujii Masao <[email protected]> writes: >> Add pg_stat_archiver statistics view. >> This view shows the statistics about the WAL archiver process's activity. > > For the record, this commit should certainly have included a catversion.h > bump. > > Usually it's the committer's responsibility to add that when necessary; > we don't ask people to include it in submitted patches because they'd > inevitably get patch conflicts depending on what order things get > committed in. > > There are a couple of rules of thumb about when to increase catversion: > > * system catalog contents no longer consistent with backend executable > (in this case, pg_proc.h versus the set of functions actually present) > > * regression tests would not pass without a fresh initdb (rules.out > change makes that true here)
Sorry, that's definitely my mistake. I know that rule, but I just completely forgot to do that... Since 105639900bf83fd3e3eb5b49f49b4d74d6347b9b increased the catalog version, I don't increase that again for now. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
