* Tom Lane ([email protected]) wrote: > Stephen Frost <[email protected]> writes: > > * Tom Lane ([email protected]) wrote: > >> I'm pretty sure you broke _CloseArchive with this hunk: > > > That'd be pretty frustrating as my testing didn't exhibit any issues. > > It's possible that errno is accidentally zero when we get there, but > the code as-committed surely can't be called bulletproof.
Agreed, oversight on my part.
The only remaining place we still clear errno in pg_dump is in
pg_backup_archive.c:checkSeek() around a similar ftello call, perhaps
that should be changed to check the result instead also?
Thanks,
Stephen
signature.asc
Description: Digital signature
