Hi,

On 2014-03-18 16:26:19 +0000, Robert Haas wrote:
> Add pg_recvlogical, a tool to receive data logical decoding data.
> 
> This is fairly basic at the moment, but it's at least useful for
> testing and debugging, and possibly more.

Inspecting the output by different compilers shows a screwup of mine,
added when introducing the fsyncing of the outputfile. There's a
unitialized variable usage when both --status-interval and
--fsync-interval are set to zero/disabled.

Greetings,

Andres Freund

-- 
 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
index a631cee..5ebf197 100644
--- a/src/bin/pg_basebackup/pg_recvlogical.c
+++ b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -321,6 +321,9 @@ StreamLog(void)
 			FD_ZERO(&input_mask);
 			FD_SET(PQsocket(conn), &input_mask);
 
+			/* no timeout for select() if both -F and -s are disabled */
+			timeoutptr = NULL;
+
 			/* Compute when we need to wakeup to send a keepalive message. */
 			if (standby_message_timeout)
 				message_target = last_status + (standby_message_timeout - 1) *
-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Reply via email to