On 2014-04-09 12:46:35 +0200, Michael Meskes wrote: > > > Several fixes to array handling in ecpg. > > > > What's actually fixed by this? > > There were a couple of reports that data got filled into array incorrectly > and at least some of those were fixed by the patches.
It'd be useful to describe that in the commit... > > The patch, or at least the comments, don't look entirely finished: > > + /* > > + * If siz i.e. the size of structure of which this variable is part > > of, > > + * that gives the offset to the next element, if required > > + */ > > Not sure what you're trying to tell me here, other than that the wording is > unclear. To me that looks like somebody tried to rewrite a comment and stopped somewhere in the middle. I don't think anybody trying to read that code in the future is going to understand it. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
