check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows.
Backpatch through 9.0. 8.4 doesn't have the infrastructure to fix this. Branch ------ REL9_0_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/a86b2dafff7c2061e0d3c9019734afcb5d0d3b7e Modified Files -------------- src/backend/libpq/auth.c | 6 +++--- src/backend/libpq/ip.c | 10 +++++----- src/backend/libpq/pqcomm.c | 4 ++-- src/backend/port/win32/socket.c | 2 +- src/backend/postmaster/postmaster.c | 2 +- src/interfaces/libpq/fe-connect.c | 34 +++++++++++++++++++++++++++++----- src/interfaces/libpq/libpq-int.h | 1 + 7 files changed, 42 insertions(+), 17 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
