On 2014-06-30 10:10:24 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > Check interrupts during logical decoding more frequently. > > FWIW, I think it's usually better style to put CHECK_FOR_INTERRUPTS > at the tops of loops rather than the bottoms. If you put it at the > bottom, it's easily bypassed unintentionally by a "continue" somewhere > in the middle of the loop body. (I suppose there could be cases where > that's actually what you want, but if so some comments would be > appropriate, because it's fragile coding.)
Ok. Will do so from now on. I wanted to put it after the expensive/slow operation which makes the check necessary - obviously putting it at the loop begin essentially has the same effect, but that seemed clearer to me. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
