Mark x86's memory barrier inline assembly as clobbering the cpu flags. x86's memory barrier assembly was marked as clobbering "memory" but not "cc" even though 'addl' sets various flags. As it turns out gcc on x86 implicitly assumes "cc" on every inline assembler statement, so it's not a bug. But as that's poorly documented and might get copied to architectures or compilers where that's not the case, it seems better to be precise.
Discussion: [email protected] To keep the code common, backpatch to 9.2 where explicit memory barriers were introduced. Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/855cabb6f59c06f3ffcddade59bfbee60dab61aa Modified Files -------------- src/include/storage/barrier.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
