Heikki Linnakangas <[email protected]> writes:
> On 11/25/2014 12:17 AM, Robert Haas wrote:
>> Add infrastructure to save and restore GUC values.
> guc.c: In function âEstimateGUCStateSpaceâ:
> guc.c:8506:7: warning: âvalsizeâ may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> Size valsize;
> ^
> guc.c: In function âSerializeGUCStateâ:
> guc.c:8762:56: warning: âi_roleâ may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> serialize_variable(&curptr, &bytes_left, guc_variables[i_role]);
> ^
I fixed the latter (my compiler was unhappy about it though not about
the former). I'm not sure whether Robert would prefer to fix
the former by adding a useless initialization or by adding a default:
to the switch. Personally I'd lean towards the initialization, though,
as a default: would suppress warnings about errors-of-omission if we
ever add more switch cases.
regards, tom lane
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
