Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thread; so no more than nclients descriptors could be leaked this way. But it's not hard to imagine future improvements whereby that wouldn't be true. In any case, it's sloppy coding, so patch all branches. Found by Coverity.
Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/6c75384eed8770b11f01378b37dc4bd07a5710f1 Modified Files -------------- contrib/pgbench/pgbench.c | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
