On 2014-12-25 14:13:08 -0500, Tom Lane wrote: > Andres Freund <[email protected]> writes: > > This broke dtrace probes in a trivial way. Looking at the log made me > > notice though that the probes in lwlock.c generate warnings since the > > tranche changes went in. > > Yeah, dtrace has never behaved very nicely with "const foo *" arguments. > This is a bug in dtrace, not in our usage of it, and I don't think we > should de-constify our code to work around the warnings.
Great, agreed. > > Personally I think at this point we could just rip the probe support > > out, but I'm not going to fight for that in earnest. > > Not without a replacement for the functionality, IMO. Fine with me, I just always had the impression that nobody uses them - I very well might be wrong. Personally I just use 'perf probe' to add tracepoints dynamically, where I need them. I assume others are doing similar things. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
