On Tue, May 12, 2015 at 1:18 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: >> Michael Paquier wrote: >>> On Tue, May 12, 2015 at 11:43 AM, Michael Paquier >>> <michael.paqu...@gmail.com> wrote: >>> > On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera >>> > <alvhe...@2ndquadrant.com> wrote: >>> >> Michael Paquier wrote: >>> >>> On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera >>> >>> <alvhe...@alvh.no-ip.org> wrote: >>> >> Not sure what's the real fix here .. >>> > >>> > I think that you should then use MODULE_big instead of MODULES, and >>> > set OBJS as "test_dll_parser.o $(WIN32RES)". >>> >>> Taking it back, listing explicitly the list of tests in the Makefile's >>> REGRESS works just fine. Patch attached. >> >> Sure. I want to avoid doing that, though: we may want to generate a >> schedule based on src/test/regress/serial_schedule, so that newly added >> tests to the regular suite are automatically considered by this module. > > Mind share more details about that? How would you detect that a given > test in serial_schedule needs to be considered by test_ddl_deparse > automatically? WIth a new type of keyword in a schedule file? This > looks like a different feature to me that's going to need more > infrastructure... > > If you want to continue on this way though, I imagine that you will > need to add a special case in fetchTests of vcregress.pl. In any case, > it is not good to keep the buildfarm machines broken for too long, and > personally I would rather avoid adding one more hack in the MSVC build > scripts.
Btw, just adding that a .gitignore file with /results/ is missing in src/test/modules/test_ddl_deparse. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers