On Fri, May 15, 2015 at 8:44 PM, Andrew Dunstan <[email protected]> wrote:
>
> On 05/15/2015 06:04 AM, Simon Riggs wrote:
>>
>> On 15 May 2015 at 04:59, Tom Lane <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>     The difference there was that that was specifically adding a new
>>     feature
>>     of value to FDWs.  This is just drive-by breakage.
>>
>>
>> I think that comment is reasonable. I will continue with my commits of
>> tablesample, then return to see if we can improve/revert the API breakage.
>>
>>
>
>
> OK, good, but I'm not going to accept Michael's pull request until the API
> is stable.

Well, I guess that this is going to be incorrect in any case now.
Still any API change can be done cleanly in a matter of minutes for
this FDW.
-- 
Michael


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Reply via email to