Fujii, Michael, * Fujii Masao (masao.fu...@gmail.com) wrote: > pg_audit uses 1.0.0 as its version number. But, is the third digit really > required? Why? We usually uses the version number with two digits in > contrib modules.
[...]
> In Makefile, PGFILEDESC should be added.
>
> +# pg_audit/Makefile
>
> should be "# contrib/pg_audit/Makefile" for the consistency.
>
> The categories of some SQL commands are different between log_statement and
> pg_audit. For example, REINDEX is treated as DDL in pg_audit, but not in
> log_statement. That's confusing. We should use the same "category-mapping"
> rule as much as possible.
[...]
* Michael Paquier (michael.paqu...@gmail.com) wrote:
> And on top of that the following things should be changed:
> - Removal of REGRESS_OPTS which is empty
> - Removal of MODULE, which overlaps with MODULE_big
> - $(WIN32RES) needs to be added to OBJS for Windows versioning
I've pushed these changes.
Thanks!
Stephen
signature.asc
Description: Digital signature
