On 07/27/2015 06:36 PM, Tom Lane wrote:
Heikki Linnakangas <[email protected]> writes:
Fix handling of all-zero pages in SP-GiST vacuum.
I'm a little bit uncomfortable with the way that this patch presumes that
PageIsEmpty (a) is safe on an all-zeroes page and (b) will return true for
such a page. Yes, it does work at the moment; but I don't think we are
making such an assumption anyplace else, and in view of your other two
concurrent patches, it doesn't seem very future-proof here either.
I recommend that the code look more like
if (!SpGistBlockIsRoot(blkno))
{
if (PageIsNew(page) || PageIsEmpty(page))
I thought I saw other places that assumed that, and I even thought I saw
a comment somewhere documenting that usage. But now that I grep around,
I see no such thing.
I'll go change that...
- Heikki
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
