Fix old oversight in join removal logic. Commit 9e7e29c75ad441450f9b8287bd51c13521641e3b introduced an Assert that join removal didn't reduce the eval_at set of any PlaceHolderVar to empty. At first glance it looks like join_is_removable ensures that's true --- but actually, the loop in join_is_removable skips PlaceHolderVars that are not referenced above the join due to be removed. So, if we don't want any empty eval_at sets, the right thing to do is to delete any now-unreferenced PlaceHolderVars from the data structure entirely.
Per fuzz testing by Andreas Seltenreich. Back-patch to 9.3 where the aforesaid Assert was added. Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/de5edc660ae09e9a2785e52d2b539f2e0def1e63 Modified Files -------------- src/backend/optimizer/plan/analyzejoins.c | 20 ++++++++++++++------ src/test/regress/expected/join.out | 16 ++++++++++++++++ src/test/regress/sql/join.sql | 15 +++++++++++++++ 3 files changed, 45 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
