On 2015-08-14 16:03:51 +0900, Michael Paquier wrote: > On Fri, Aug 14, 2015 at 3:50 PM, Andres Freund <[email protected]> wrote: > > On 2015-08-14 15:32:17 +0900, Michael Paquier wrote: > >> Why hasn't this addition been spread as well in the replication > >> protocol? It seems to me that most of the refactoring work has been > >> done with ReplicationSlotReserveWal. > > > > Feel free to send a patch. > > I don't mind giving it a try if time allows... CREATE_REPLICATION_SLOT > IDENT K_PHYSICAL slot_options? With slot_options: (reserve = on/off)?
Let's discuss that in the -hackers thread. I slightly doubt the generic options (which don't exist for CREATE) are a good place for that, they're for the output plugin, this isn't. I think a separate keyword might be easier. > And, actually, here is an unrelated patch, the docs are referring to > confirmed_flush instead of confirmed_flush_lsn ;) Ick, will apply. Greetings, Andres Freund -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
