Make viewquery a copy in rewriteTargetView() Rather than expect the Query returned by get_view_query() to be read-only and then copy bits and pieces of it out, simply copy the entire structure when we get it. This addresses an issue where AcquireRewriteLocks, which is called by acquireLocksOnSubLinks(), scribbles on the parsetree passed in, which was actually an entry in relcache, leading to segfaults with certain view definitions. This also future-proofs us a bit for anyone adding more code to this path.
The acquireLocksOnSubLinks() was added in commit c3e0ddd40. Back-patch to 9.3 as that commit was. Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/f02137da88c49125a20d7c51ae9932e47eb61f93 Modified Files -------------- src/backend/rewrite/rewriteHandler.c | 34 ++++++++----- src/test/regress/expected/updatable_views.out | 67 +++++++++++++++++++++++++ src/test/regress/sql/updatable_views.sql | 44 ++++++++++++++++ 3 files changed, 133 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
