On 20 February 2016 at 10:33, Michael Paquier <michael.paqu...@gmail.com> wrote:
> On Sat, Feb 20, 2016 at 7:17 PM, Dean Rasheed <dean.a.rash...@gmail.com> 
> wrote:
>> On 20 February 2016 at 10:12, Michael Paquier <michael.paqu...@gmail.com> 
>> wrote:
>>> Happy first commit.
>>
>> Arg. Not so much.
>>
>> Looks like I broke something -- looking into it now :-(
>
> The terabyte conversion is at fault:
> Expected:
> !  -1tb      |    -1099511627776
> Result:
> !  -1tb      |            -1
>
> +       else if (pg_strcasecmp(strptr, "gb") == 0)
> +           multiplier = 1024 * 1024 * 1024;
> +       else if (pg_strcasecmp(strptr, "tb") == 0)
> +           multiplier = 1024 * 1024 * 1024 * 1024L;
> Why adding an 'L' here?

Ah, looks like it needs to be 'LL' because it needs to be a 64-bit literal.

Regards,
Dean


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Reply via email to