On 20 February 2016 at 14:54, Tom Lane <[email protected]> wrote: > Dean Rasheed <[email protected]> writes: >> Fix pg_size_bytes() to be more portable. >> Commit 53874c5228fe16589a4d01b3e1fab3678e0fd8e3 broke various 32-bit >> buildfarm machines because it incorrectly used an 'L' suffix for what >> needed to be a 64-bit literal. Thanks to Michael Paquier for helping >> to diagnose this. > > That's still not right: not all compilers support "long long", and the > ones that don't won't have "LL" notation either. > > Project style is to use something like "(uint64) 1024" instead. >
OK, will fix. BTW, I found a couple of instances of 'LL' in ecpglib/prepare.c, which is why I thought it was OK to use it. Regards, Dean -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
