On 02/21/2016 08:38 AM, Tom Lane wrote: > Coverity griped about use of unchecked strcpy() into a local variable. > There's unlikely to be any actual bug there, since no caller would be > passing a path longer than MAXPGPATH, but nonetheless use of strlcpy() > seems preferable.
FWIW, strcpy() was being used in src/bin/pg_config/pg_config.c that I started with -- does that mean we are not getting Coverity coverage of src/bin? > While at it, get rid of unmaintainable separation between list of > field names and list of field values in favor of initializing them > in parallel. I waffled back and forth about doing something similar and apparently landed on the wrong side of it :-). I'll take a similar tack with the controldata patch that I'm trying to get over the finish line. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development
signature.asc
Description: OpenPGP digital signature