Be pickier about converting between Name and Datum. We were misapplying NameGetDatum() to plain C strings in some places. This worked, because it was just a pointer cast anyway, but it's a type cheat in some sense. Use CStringGetDatum instead, and modify the NameGetDatum macro so it won't compile if applied to something that's not a pointer to NameData. This should result in no changes to generated code, but it is logically cleaner.
Mark Dilger, tweaked a bit by me Discussion: <[email protected]> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/55c3391d1e6a201b5b891781d21fe682a8c64fe6 Modified Files -------------- src/backend/commands/dbcommands.c | 8 ++++---- src/backend/commands/proclang.c | 2 +- src/backend/commands/typecmds.c | 2 +- src/include/postgres.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
