On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Ugh, yes. Sorry, I should have checked this more carefully before >> commit. I mentioned the problem in a previous review and failed to >> notice that it hadn't been fixed. Are you taking care of it at this >> point or should I keep at it? > > I'm about to push a fix that removes the crashes (or at least the ones > I see on dromedary),
For comparison, a patch I wrote by inspection is attached. > but there is still a problem, which is that the > expected output seems inherently platform-dependent: > > I think probably both of those are unavoidable 32-bit v 64-bit > differences due to available space on a page changing with MAXALIGN. > What do you want to do about those? How about we have the test just select a named list of fields instead of selecting *? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
fixes.patch
Description: Binary data
-- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
