On 2017-04-06 17:03:20 -0500, Kevin Grittner wrote: > On Thu, Apr 6, 2017 at 4:19 PM, Andres Freund <and...@anarazel.de> wrote: > > > My compiler, quite justifiedly, complains: > > > > /home/andres/src/postgresql/src/backend/parser/parse_relation.c: In > > function ‘get_rte_attribute_is_dropped’: > > /home/andres/src/postgresql/src/backend/parser/parse_relation.c:2899:43: > > warning: comparison between pointer and zero character constant > > [-Wpointer-compare] > > (list_nth(rte->coltypes, attnum - 1) != InvalidOid); > > ^~ > > /home/andres/src/postgresql/src/backend/parser/parse_relation.c:2899:7: > > note: did you mean to dereference the pointer? > > (list_nth(rte->coltypes, attnum - 1) != InvalidOid); > > ^ > > Good catch. Will push a change from list_nth() to list_nth_oid() > for the benefit of stricter compilers. While I'm at it, I'll throw > on another layer of parentheses to ensure people read that > correctly. Out of curiosity, what compiler or setting catches this?
gcc-7 here, and the specific warning is -Wpointer-compare. - Andres -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
