On 7/26/17 22:49, Andrew Dunstan wrote: > Work around Msys weakness in Testlib.pm's command_like() > > When output of IPC::Run::run () is redirected to scalar references, in > certain circumstances the Msys perl does not correctly detect that the > end of file has been seen, making the test hang indefinitely. One such > circumstance is when the command is 'pg_ctl start', and such a change > was made in commit f13ea95f9e. The workaround, which only applies on > MSys, is to redirect the output to temporary files and then read them in > when the process has finished.
This commit message contains interesting information that would be useful to record in a code comment. Otherwise it's not really clear when or why to use the "safe" variant. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
