Try to deliver a sane message for _create_locale() failure on Windows. We were just printing errno, which is certainly not gonna work on Windows. Now, it's not entirely clear from Microsoft's documentation whether _create_locale() adheres to standard Windows error reporting conventions, but let's assume it does and try to map the GetLastError result to an errno. If this turns out not to work, probably the best thing to do will be to assume the error is always ENOENT on Windows.
This is a longstanding bug, but given the lack of previous field complaints, I'm not excited about back-patching it. Per report from Murtuza Zabuawala. Discussion: https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuaje+nqhn2cgjllx78anydmi...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1e165d05fe06a9072867607886f818bc255507db Modified Files -------------- src/backend/utils/adt/pg_locale.c | 9 +++++++-- src/test/regress/expected/collate.out | 3 +++ src/test/regress/sql/collate.sql | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
