Fix replication origin-related race conditions

Similar to what was fixed in commit 9915de6c1cb2 for replication slots,
but this time it's related to replication origins: DROP SUBSCRIPTION
attempts to drop the replication origin, but that fails if the
replication worker process hasn't yet marked it unused.  This causes
failures in the buildfarm:
ERROR:  could not drop replication origin with OID 1, in use by PID 34069

Like the aforementioned commit, fix by having the process running DROP
SUBSCRIPTION sleep until the worker marks the the replication origin
struct as free.  This uses a condition variable on each replication
origin shmem state struct, so that the session trying to drop can sleep
and expect to be awakened by the process keeping the origin open.

Also fix a SGML markup in the previous commit.




Modified Files
doc/src/sgml/monitoring.sgml             |  8 +++--
src/backend/commands/subscriptioncmds.c  |  2 +-
src/backend/postmaster/pgstat.c          |  3 ++
src/backend/replication/logical/origin.c | 57 ++++++++++++++++++++++++++------
src/include/pgstat.h                     |  1 +
src/include/replication/origin.h         |  2 +-
6 files changed, 58 insertions(+), 15 deletions(-)

Sent via pgsql-committers mailing list (
To make changes to your subscription:

Reply via email to