On Mon, Oct 2, 2017 at 8:08 AM, Andres Freund <and...@anarazel.de> wrote: > Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h. > > All postgres internal usages are replaced, it's just libpq example > usages that haven't been converted. External users of libpq can't > generally rely on including postgres internal headers. > > Note that this includes replacing open-coded byte swapping of 64bit > integers (using two 32 bit swaps) with a single 64bit swap. > > Where it looked applicable, I have removed netinet/in.h and > arpa/inet.h usage, which previously provided the relevant > functionality. It's perfectly possible that I missed other reasons for > including those, the buildfarm will tell.
Thanks for taking the time to improve that! I was looking for a 64b equivalent not long ago for pg_rewind... Those changes look good to me at quick glance. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
