Hi,
On 2017-10-12 13:55:07 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2017-10-12 11:30:00 -0400, Tom Lane wrote: > >> I don't actually see why you need a #define at all --- "restrict" is the > >> standard spelling of the keyword no? > > > It is, but a lot of compilers name it differently, e.g. __restrict in > > the case of msvc. > > It's 2017 and they're still not C99 compliant? Oh well. ... > TBH, I really doubt that restrict buys us enough performance to justify > dealing with this. I'd just revert that change altogether. It's quite noticeable, and there's plenty of other case where it seems likely to be beneficial. > Or, if you insist on having it, we're going to have to go the pg_restrict > route. I don't see why that means duplicating any configure logic: on > non-Windows we can use the autoconf probe and then write > "#define pg_restrict restrict". Yea, that should work. I'll try to come up with a patch. Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers