On Wed, Oct 30, 2019 at 01:29:48PM +0900, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> > My reading of the commit message is that the error messages will just be
> > more helpful now, not that some things would now error that use to be
> > ignored. I am still unclear exactly what the release notes should say.
>
> Nay. It could be worse as in some cases like for the keepalive
> parameters, the values would be just silently ignored. Please let me
> suggest the attached for the release notes of REL_12_STABLE.
Thanks for the patch. I slightly modified the wording and applied the
attached patch.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
new file mode 100644
index 126d614..337a7a2
*** a/doc/src/sgml/release-12.sgml
--- b/doc/src/sgml/release-12.sgml
*************** Author: Peter Eisentraut <pete...@gmx.ne
*** 654,659 ****
--- 654,681 ----
</para>
</listitem>
+ <listitem>
+ <!--
+ Author: Michael Paquier <mich...@paquier.xyz>
+ 2018-09-12 [e7a221797] Parse more strictly integer parameters from connection
s
+ -->
+
+ <para>
+ Parse libpq integer connection parameters more strictly (Fabien
+ Coelho)
+ </para>
+
+ <para>
+ In previous releases, using an incorrect integer value for
+ connection parameters <literal>connect_timeout</literal>,
+ <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+ <literal>keepalives_idle</literal>,
+ <literal>keepalives_interval</literal> and <literal>port</literal>
+ resulted in libpq either ignoring those values or failing with
+ incorrect error messages.
+ </para>
+ </listitem>
+
</itemizedlist>
</sect2>
