On Fri, Dec 20, 2019 at 07:29:33AM -0700, David G. Johnston wrote:
> This has the same "match by name" possibility when I read it...
>
> I don't see the benefit of repeating "If a column list is specified" a second
> time in the three sentence paragraph. To a lesser extent the same goes for
> the
> second repetition of COPY FROM.
>
> I agree with the general goal of trying to get rid of the parenthetical; to
> that end:
> <command>COPY FROM</command> will match all listed columns in the table to
> *all* file columns by position.
>
> That sufficiently implies the "must have equal numbers" and, frankly, if
> someone gets that part wrong the immediate failure combined with re-reading
> the
> word "all" should provide sufficient clarity.
>
> So I'm still for Tom and mine combined proposal with cleaning up the middle
> sentence even more.
>
> The other point of note is the difference between:
>
> will receive their default value
> and
> will insert the default values
>
> The system is inserting default values but the columns are receiving them.
> The
> sentence is relative to the table columns though so "receive" seems like the
> better fit. Minor point overall though.
OK, this wording is obviously harder than I thought. Updated patch
attached.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
new file mode 100644
index d9b7c4d..a99f815
*** a/doc/src/sgml/ref/copy.sgml
--- b/doc/src/sgml/ref/copy.sgml
*************** COPY { <replaceable class="parameter">ta
*** 61,71 ****
</para>
<para>
! If a list of columns is specified, <command>COPY</command> will
! only copy the data in the specified columns to or from the file.
! If there are any columns in the table that are not in the column list,
! <command>COPY FROM</command> will insert the default values for
! those columns.
</para>
<para>
--- 61,71 ----
</para>
<para>
! If a column list is specified, <command>COPY TO</command> copies only
! the data in the specified columns to the file. For <command>COPY
! FROM</command>, each field in the file is inserted, in order, into the
! specified column. Table columns not specified in the <command>COPY
! FROM</command> column list will receive their default values.
</para>
<para>
