On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote: > On 2020/09/14 11:19, btkatsuragiyu wrote: >> Although csvlog has the leader_pid field, the document of file-fdw >> that uses csvlog as an example does not reflect this fact. >> Concretely, the DDL for table definition does not have the leader_pid field. > > This seems an oversight of commit b8fdee7d0c.
Dammit, I thought that I had all the places for that stuff done. The patch looks fine to me. >> This patch fixes the DDL in the document of file-fdw. > > Thanks for the patch! LGTM. I will commit it. Hmm. Instead of keeping a copy-paste of the same table in both config.sgml and file-fdw.sgml, why not having only one? It seems to me that we could just have the file_fdw doc refer to the main configuration, and it is not difficult to guess how the CREATE TABLE query needs to be changed to map with foreign table. -- Michael
signature.asc
Description: PGP signature
