On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
> The syntax for like_option in CREATE TABLE docs seems to forget to mention
> INCLUDING COMPRESSION option. I think the following fix is necessary.
> Patch attached.
> 
> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | 
> IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS 
> | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }

Indeed.  May I ask at the same time why gram.y (TableLikeOption) and
parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
option in alphabetical order with the rest?  Ordering them makes
easier a review of them.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to