"tanghy.f...@fujitsu.com" <tanghy.f...@fujitsu.com> writes:
> On Thursday, May 27, 2021 10:58 AM, Tom Lane <t...@sss.pgh.pa.us> wrote
>> So I ended up with the attached --- what do you think?

> The doc-fix LGTM. 
> But I couldn't apply the patch at HEAD(2941138e60). Maybe you did the fix at 
> a branch other than HEAD?

No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.

>> Also, looking at this, I note that "~/.pg_service.conf" is still a
>> platform-ism.  We could make that slightly better by writing
>> "$HOME/.pg_service.conf", but is that good enough?

> Agreed. Besides, A lot of places in current Doc have been useing ~/.pg_*** 
> already.
> IMHO, it's good to keep the consistency.

Oh, good point ... grepping finds lots of occurrences of '~/' and
only one of '$HOME/'.  Seems like we ought to change that one:

$ grep -r 'HOME/' .
./config.sgml:        This writes out files to 
<filename>$HOME/.debug/jit/</filename>; the

                        regards, tom lane


Reply via email to